FormStash: Display index of stashes #10161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the user could more easily track where he is...
ghost
assigned 
|
+1 |
RussKie
approved these changes
Aug 21, 2022
gerhardol
approved these changes
Aug 21, 2022
There was a problem hiding this comment.
The index used in stash is a parsed from the reflog selector (the stash name like "stash{0}") required to pop and drop stashes. (git-stash apply can be done with a sha).
This parsing may fail if Git changes the format.
But that is not an issue affected by this PR.
gerhardol
pushed a commit
that referenced
this pull request
Aug 25, 2022
so that the user could more easily track where he is... (cherry picked from commit 156b2e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the user could more easily track where he is...
(I always found painful to use the stashes ComboBox when you have a lot of stashs and stash index really help me to find the current selected stash once you scroll in the list --because the ComboBox doesn't highlight the current selected item 馃槩--)
Proposed changes
Screenshots
Before
Let's play a game: Could you find the currently selected one?
After
And now?
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
鉁掞笍 I contribute this code under The Developer Certificate of Origin.