Insert artificial commits if filter without any matches is applied #10163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Handle selection after refresh if artificial commits are removed from the view
gerhardol
force-pushed
the
feature/i10162-artificial-TryGetParents
branch
from
25b7a17
to
2b19a57
Compare
gerhardol
commented
Aug 22, 2022
Comment on lines
1328
to
1338
| if (notSelectedId.IsArtificial) | ||
| { | ||
| notSelectedId = CurrentCheckout is not null | ||
| ? CurrentCheckout | ||
| : _gridView.ToBeSelectedObjectIds.Where(id => !id.IsArtificial).FirstOrDefault(); | ||
| } | ||
|
|
||
| if (notSelectedId is not null) | ||
| { | ||
| parents = TryGetParents(Module, _filterInfo, notSelectedId); | ||
| } |
There was a problem hiding this comment.
To keep it simple, the following can be reduced with the drawback that unselecting ShowArtificial while artificial is selected will not select anything
Suggested change
| if (notSelectedId.IsArtificial) | |
| { | |
| notSelectedId = CurrentCheckout is not null | |
| ? CurrentCheckout | |
| : _gridView.ToBeSelectedObjectIds.Where(id => !id.IsArtificial).FirstOrDefault(); | |
| } | |
| if (notSelectedId is not null) | |
| { | |
| parents = TryGetParents(Module, _filterInfo, notSelectedId); | |
| } | |
| if (!notSelectedId.IsArtificial) | |
| { | |
| parents = TryGetParents(Module, _filterInfo, notSelectedId); | |
| } |
There was a problem hiding this comment.
Simplified this, added a comment instead
(The snippet was written when the solution was slightly different, I kept it though)
mstv
approved these changes
Aug 22, 2022
…lied Handle selection after refresh if artificial commits are removed from the view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10162
Proposed changes
Handle selection after refresh if artificial commits are
removed from the view
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.