New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update-DotnetVersion script #10191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 works as promised
file output as UTF8 would be useful
results could be printed on the console, too (although they are visible in GE)
@mstv Sure. Making sure flipping flag on build works and I can add output and utf8 fix. |
289ab16
to
c83bf77
Compare
55ef628
to
bd49888
Compare
@mstv Last check to make sure update script doesn't run when flag is off and then this is good to go. |
@mstv Verified. This is good to go. You can manually run script to update or if wanting to see if sdk/runtime change breaks something change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Few comments primarily of stylistic nature.
188e395
to
7f71ed5
Compare
Updates .NET SDK and Runtime versions together Allows for .\Scripts\Update-DotnetVersion.ps1 OR .\Scripts\Update-DotnetVersion.ps1 7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Updates dotnet SDK and Runtime versions together
Allows for
.\Scripts\Update-DotnetVersion.ps1
OR
resolves #10192
Proposed changes
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.