Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update-DotnetVersion script #10191

Merged
merged 2 commits into from Sep 13, 2022
Merged

Add Update-DotnetVersion script #10191

merged 2 commits into from Sep 13, 2022

Conversation

vbjay
Copy link
Contributor

@vbjay vbjay commented Sep 11, 2022

Updates dotnet SDK and Runtime versions together

Allows for

.\Scripts\Update-DotnetVersion.ps1

OR

.\Scripts\Update-DotnetVersion.ps1 7.0

resolves #10192

Proposed changes

  • Add script to allow updating dotnet version to latest of current version used or passing in a specified version
  • Update appveyor build to allow user to set flag that causes the latest version to be used in build. Useful to test version bump before applying the change.

Test methodology

  • Ran script and verified change

Test environment(s)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned vbjay Sep 11, 2022
@vbjay vbjay mentioned this pull request Sep 11, 2022
@vbjay vbjay changed the title Add Update-DotnetVersion script WIP Add Update-DotnetVersion script Sep 11, 2022
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 works as promised
file output as UTF8 would be useful
results could be printed on the console, too (although they are visible in GE)

@vbjay
Copy link
Contributor Author

vbjay commented Sep 11, 2022

@mstv Sure. Making sure flipping flag on build works and I can add output and utf8 fix.

@vbjay vbjay force-pushed the updateDotnet branch 5 times, most recently from 289ab16 to c83bf77 Compare September 11, 2022 21:45
@vbjay vbjay changed the title WIP Add Update-DotnetVersion script Add Update-DotnetVersion script Sep 11, 2022
@vbjay vbjay force-pushed the updateDotnet branch 3 times, most recently from 55ef628 to bd49888 Compare September 11, 2022 22:49
@vbjay
Copy link
Contributor Author

vbjay commented Sep 11, 2022

@mstv Last check to make sure update script doesn't run when flag is off and then this is good to go.

@vbjay
Copy link
Contributor Author

vbjay commented Sep 11, 2022

@mstv Verified. This is good to go.

You can manually run script to update or if wanting to see if sdk/runtime change breaks something change
image
to make appveyor run script before install.

Sample output
image

@vbjay vbjay requested a review from mstv September 11, 2022 23:23
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Few comments primarily of stylistic nature.

scripts/Mark-RepoClean.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
scripts/Update-DotnetVersion.ps1 Outdated Show resolved Hide resolved
@vbjay vbjay force-pushed the updateDotnet branch 3 times, most recently from 188e395 to 7f71ed5 Compare September 12, 2022 03:31
Updates .NET SDK and Runtime versions together

Allows for
.\Scripts\Update-DotnetVersion.ps1
OR
.\Scripts\Update-DotnetVersion.ps1 7.0
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstv mstv merged commit af94e7c into gitextensions:master Sep 13, 2022
@ghost ghost added this to the vNext milestone Sep 13, 2022
@vbjay vbjay deleted the updateDotnet branch September 14, 2022 05:44
@gerhardol gerhardol modified the milestones: vNext, 4.0.0 Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update-DotnetVersion script
4 participants