Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellExtension: rename item in the setting form with same name it have in shell extension menu #10217

Merged
merged 2 commits into from Oct 8, 2022

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Oct 3, 2022

4 years later followup of #5117

Shell menu since #5117:

image

Screenshots

Before

image

After

image

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build b78e768d55af39e5d79310d8f1b7e772cefcf30a (Dirty)
  • Git 2.35.1.windows.2 (recommended: 2.37.1 or later)
  • Microsoft Windows NT 10.0.19042.0
  • .NET 6.0.8
  • DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned pmiossec Oct 3, 2022
@pmiossec
Copy link
Member Author

pmiossec commented Oct 3, 2022

Looking at the Shell Extension code, I have a question:

The shell extension menu is not translated because the strings are hard-coded in the cpp project (and so don't benefit of the translation strings).
So, does that makes sense to have the strings translated in the "Context menu preview" (here in french) whereas in fact the user will never have it in his language?
image

My point of view is that we should prevent the strings to be translated.

@gerhardol
Copy link
Member

gerhardol commented Oct 3, 2022

The shell extension menu is not translated because the strings are hard-coded in the cpp project (and so don't benefit of the translation strings). So, does that makes sense to have the strings translated in the "Context menu preview" (here in french) whereas in fact the user will never have it in his language?

Seem to be better to drop the translation if the shell extension is not translated
(__NO_TRANSLATE_ prefixes)

@RussKie
Copy link
Member

RussKie commented Oct 4, 2022

Looking at the Shell Extension code, I have a question:

The shell extension menu is not translated because the strings are hard-coded in the cpp project (and so don't benefit of the translation strings). So, does that makes sense to have the strings translated in the "Context menu preview" (here in french) whereas in fact the user will never have it in his language? image

My point of view is that we should prevent the strings to be translated.

Good point. For consistency we can drop the translations.

@pmiossec
Copy link
Member Author

pmiossec commented Oct 6, 2022

Good point. For consistency we can drop the translations.

Done.

@RussKie RussKie merged commit 24e208f into gitextensions:master Oct 8, 2022
@ghost ghost added this to the vNext milestone Oct 8, 2022
@RussKie RussKie modified the milestones: vNext, 4.0.0 Oct 8, 2022
RussKie pushed a commit that referenced this pull request Oct 8, 2022
…e in shell extension menu (#10217)

(cherry picked from commit 24e208f)
@pmiossec pmiossec deleted the fix_contextualmenu_string branch October 8, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants