New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FormManageWorktree layout #10244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seem ok, but why have Create on separate "line"?
<metadata name="Branch.UserAddedColumn" type="System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"> | ||
<value>True</value> | ||
</metadata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate, also 66-68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merriemcgaw @KlausLoeffelmann this happened again, but I can't really replicate it. Version 17.4.0 Preview 2.1
"Create" is an contextless operation - i.e., it applies to the whole dialog, where as "Open selected" and "Delete selected" apply to the selection - i.e., these are context-aware. I wasn't sure about the "Prune" button, so placed it in the "context aware" section, but I'm not sure if it's appropriate. |
OK |
6d88f00
to
6923196
Compare
Updated |
Thank you |
(cherry picked from commit 923851b)
Contributes to #6183
Proposed changes
GitExtensionsDialog
FormManageWorktree_Load
handler and invokeInitialize
inOnRuntimeLoad
Screenshots
Before
After
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.