Redo selection of the first item to fix shift-select of multiple items #10253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
When opening FormCommit - first item in unstaged files is selected. Then when shift-clicking on 2nd and further items to select 1fst through clicked items, the selection is made not from the top but from the bottom.
Proposed changes
Selected
totrue
for the first selected item.Screenshots
Before
Notice that when
shift-clicking
after refresh control acts as if last item in the list has focus and selection happens from it till the item being clicked on.After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.