FormCreateWorktree: Build potential worktree path using repository path #10290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Oct 25, 2022
RussKie
added
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
instead of the currently checked out worktree that probably contains information related to the branch checked out
pmiossec
force-pushed
the
worktree_better_branch_naming_proposition
branch
from
c9115a9
to
1029544
Compare
|
done. |
RussKie
reviewed
Oct 28, 2022
| { | ||
| return string.Join("_", branchName.Split(_invalidCharsInPath, StringSplitOptions.RemoveEmptyEntries)).TrimEnd('.'); | ||
| } | ||
| string NormalizeBranchName(string branchName) => string.Join("_", branchName.Split(_invalidCharsInPath, StringSplitOptions.RemoveEmptyEntries)).TrimEnd('.'); |
There was a problem hiding this comment.
We have branch normalisation strategies we use in the branch dialog. Should we use the same?
Not asking to do it here, just making an observation.
RussKie
approved these changes
Oct 28, 2022
mstv
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the currently checked out worktree
that probably contains information related to the branch checked out
Screenshots
Before
The directory path proposed for the new worktree is based on the current checked out worktree (so the path proposed could be strange if it contains the name of the branch in the path)
After
Whatever is the worktree checked out, the path proposed is based on the main git repo path
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.