FormBrowse: let the user add fetch/pull custom icons in the toolbar #10293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
approved these changes
Oct 26, 2022
RussKie
reviewed
Oct 27, 2022
| @@ -12,6 +12,8 @@ partial class FormBrowse | |||
| { | |||
| // This file is dedicated to init logic for FormBrowse menus and toolbars | |||
|
|
|||
| public const string PullShortcutsPrefix = "pull_shortcut_"; | |||
There was a problem hiding this comment.
Suggested change
| public const string PullShortcutsPrefix = "pull_shortcut_"; | |
| internal const string PullShortcutsPrefix = "pull_shortcut_"; |
pmiossec
force-pushed
the
fetch_pull_button_in_toolbar
branch
from
b5ec77d
to
ce3ae45
Compare
|
Done. Should be merged after #10294 (because the settings save is based on the same code change, because the default value is 'false') |
mstv
approved these changes
Oct 28, 2022
pmiossec
force-pushed
the
fetch_pull_button_in_toolbar
branch
2 times, most recently
from
756a928
to
438882d
Compare
Done.
Yes, that's not very risky PRs. But I think @RussKie was interested to have #10294 or #10235 merged in v4... |
pmiossec
force-pushed
the
fetch_pull_button_in_toolbar
branch
from
da08947
to
c5f6942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement over #3923
Proposed changes
Screenshots
Before
After
Configuration:
Result (because I want a fetch button distinct of a pull button --like in all the other git GUIs--):
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.