Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recent repository list keyboard navigation #10400

Merged
merged 2 commits into from Nov 14, 2022

Conversation

mdonatas
Copy link
Contributor

Fixes (none)

Proposed changes

  • Select the first item when recent repository list gets focus
  • Give focus to recent repository list when pressing ⬇️ arrow key in a filter search box
  • Give focus to filter search box when pressing ⬆️ in a recent repository list when the top item (in any column) is selected

Screenshots

Before

Notice how when pressing tab while in a filter search box it's not obvious which control gets focus
recent-repo-arrow-no-keys

After

Full back and forth navigation between the list and the search box with arrow keys
recent-repo-arrow-keys

Test methodology

  • Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned mdonatas Nov 14, 2022
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussKie RussKie added area: dashboard Issues related to the Dashboard 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity labels Nov 14, 2022
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Nov 14, 2022
@RussKie RussKie merged commit bc2dc84 into gitextensions:master Nov 14, 2022
@ghost ghost added this to the vNext milestone Nov 14, 2022
@RussKie
Copy link
Member

RussKie commented Nov 14, 2022

Thank you

@mdonatas mdonatas deleted the recent-repo-dashboard-ux branch November 15, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dashboard Issues related to the Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants