CommitInfo: Copy only essential & stable data to clipboard

[mstv]

Proposed changes

Do not copy the following CommitInfo content to the clipboard any longer:

• tabulator(s) after the :
• relative time
• child and parent hashes
• entire lower panel:
  • related links
  • "contained in branches / tags"
  • "derives from tag"

Screenshots

Before

Author:		Philippe Miossec <pmiossec@gmail.com>
Date:		1 day ago (16.11.2022 07:41:44)
Committer:	GitHub <noreply@github.com>
Commit hash:	6f9591c6ad0d0d4ab6970fa1c837560a9e743e3c
Children:	d10fc120 68d45919 4948ebac 87207d96
Parent:		9fd9895d

FormBrowse: let the user add fetch/pull custom icons in the toolbar (#10293)
Related links: View on GitHub, Issue 10293

Contained in branches:
feature/copy_commit_info
upstream/master
feature/7982_explorer_integration
fix/10414_derived_from_tag
upstream/HEAD
mstv/feature/7982_explorer_integration
mstv/feature/copy_commit_info
mstv/fix/10414_derived_from_tag
z_philippe/all_to_upstream
z_philippe/editnetspell_autocomplete
z_philippe/settings_button_split

Contained in no tag

Derives from no tag

After

Author: Philippe Miossec <pmiossec@gmail.com>
Date: 16.11.2022 07:41:44
Committer: GitHub <noreply@github.com>
Commit hash: 6f9591c6ad0d0d4ab6970fa1c837560a9e743e3c

FormBrowse: let the user add fetch/pull custom icons in the toolbar (#10293)

Test methodology

• add NUnit testcases

Test environment(s)

• Git Extensions 33.33.33
• Build 47b630a
• Git 2.38.1.windows.1
• Microsoft Windows NT 10.0.19045.0
• .NET 6.0.10
• DPI 96dpi (no scaling)
• Microsoft.WindowsDesktop.App Versions

    Microsoft.WindowsDesktop.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

---

✒️ I contribute this code under The Developer Certificate of Origin.

[vbjay]

I disagree. It's super easy to remove what is not desired. If you want to do this, do a brief and full sub menu options that let's the user pick which way.

[mstv]

do a brief and full sub menu options that let's the user pick which way.

Perhaps that will be the compromise. I want to get more opinions.

It's super easy to remove what is not desired.

I cannot agree to this. It is a nuisance in the current form.

If you really need the stuff from the lower panel, click it, Ctrl+A, Ctrl+C.
Revision links are pretty useless as text.

[crypto-rsa]

Please note there was a quite lengthy discussion on enhancing copying information from the CommitInfo panel. I was the author of the original PR but it hit a dead end. I still think there could be a richer set of items to copy from that panel. Is reusing the Copy to clipboard revision grid submenu still an option?

[RussKie]

This looks like a feature and not a fix, why are we targeting 4.0.x for this?

[mstv]

This looks like a feature and not a fix, why are we targeting 4.0.x for this?

Because it does not affect the translation (and it is at the margin between a feature and a fix).

Is reusing the Copy to clipboard revision grid submenu still an option?

IMO this makes perfect sense. In a follow-up PR, we can move the Copy commit info item to this submenu as Commit &info, add another item C&ommit details and provide the submenu in both locations.
For the CommitInfo panel, a Copy &selection in addition below the Copy link.

So rather merge this PR just for vNext because there will be a follow-up.