Do not store the default value of a NumberSetting #10445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because NumericUpDown cannot indicate a null value (fixup for gitextensions#9119, fixes gitextensions#10323)
RussKie
approved these changes
Nov 23, 2022
gerhardol
reviewed
Nov 25, 2022
|
I have added "Always display the default value if nothing is set (not only for "effective")" to the description. |
ghost
added this to the
mstv
added a commit
that referenced
this pull request
Nov 26, 2022
This was referenced Dec 6, 2022
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10323
Proposed changes
because NumericUpDown cannot indicate a null value
(The binding was created in [NBug] Value was either too large or too small for an Int32. #9119.)
Screenshots
Before
NRE
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.