Conemu: fix switch of repo folder in console tab #10613
Conversation
ConEmu handling of new line should have changed (and the cursor is now passing to the next line and no more run the command entered in the prompt) so now sending the "Enter" key so that the "cd" command is run Fixes gitextensions#9761 (comment) For ConEmu macro keys: https://conemu.github.io/en/GuiMacro.html#Keys
ghost
assigned 
| break; | ||
|
|
||
| default: | ||
| terminal.RunningSession.WriteInputTextAsync($"\x1B{command}{Environment.NewLine}"); | ||
| terminal.RunningSession.WriteInputTextAsync($"\x1B{command}"); |
There was a problem hiding this comment.
🤔hummm.... I don't get it.
I have remove the new line because it is no more working in ConEmu and replace by sending the Enter key to run the command...
There was a problem hiding this comment.
The first case is BashShell.ShellName, no \x1B
Is the macro invoked in both situations, what is the difference?
How to test both paths?
There was a problem hiding this comment.
The first case if for bash where we use a macro because it doesn't react like other shells (cmd, powershell, pwsh) that clean the command line when you print the Esc ( \x1B ) char.
Is the macro invoked in both situations, what is the difference?
Then the macro to send Enter is used to press ENter in both cases (now that printing new line doesn't work anymore)
How to test both paths?
Switching the default shell
ConEmu handling of new line should have changed
(and the cursor is now passing to the next line and no more run the command entered in the prompt) so now sending the "Enter" key so that the "cd" command is run
Fixes #9761 (comment)
Fixes #10610
For ConEmu macro keys: https://conemu.github.io/en/GuiMacro.html#Keys
Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.