Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally show EOL markers as glyph instead of textually #10697

Merged
merged 3 commits into from Feb 12, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 3, 2023

Proposed changes

  • Add option to toggle end-of-line markers between glyph and text
  • Focus Type to find field on open of FormSettings

Screenshots

Before / After

image image

Before

image

After

image

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 26a3cdb
  • Git 2.39.0.windows.1
  • Microsoft Windows NT 10.0.19045.0
  • .NET 6.0.12
  • DPI 96dpi (no scaling)
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv added this to the vNext milestone Feb 3, 2023
@mstv mstv self-assigned this Feb 3, 2023
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
But I want the checkbox on a separate line

@RussKie
Copy link
Member

RussKie commented Feb 4, 2023 via email

@mstv
Copy link
Member Author

mstv commented Feb 4, 2023

But I want the checkbox on a separate line

I can do that. But this setting only applies to views using the "Code font".

@mstv
Copy link
Member Author

mstv commented Feb 10, 2023

But I want the checkbox on a separate line

I can do that. But this setting only applies to views using the "Code font".

Do you still want an unrelated CheckBox on a separate line?

@gerhardol
Copy link
Member

Do you still want an unrelated CheckBox on a separate line?

Yes, maybe some separating line or group box.
But +1 from me still applies, if you do not bother, please merge.

@mstv mstv merged commit f4ca8cf into gitextensions:master Feb 12, 2023
@mstv mstv deleted the feature/eol_symbols branch February 12, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants