Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditNetSpell: Avoid unhandled-key sound for cursor keys #10715

Merged
merged 1 commit into from Feb 12, 2023
Merged

EditNetSpell: Avoid unhandled-key sound for cursor keys #10715

merged 1 commit into from Feb 12, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 11, 2023

Proposed changes

  • Mark cursor key presses as handled if the EditNetSpell's RichTextBox has not handled them
    in order to suppress the unhandled-key sound ("ding")
    primarily when editing the commit message

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build ce37b9d
  • Git 2.39.0.windows.1
  • Microsoft Windows NT 10.0.19045.0
  • .NET 6.0.12
  • DPI 96dpi (no scaling)
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv added this to the vNext milestone Feb 11, 2023
@mstv mstv self-assigned this Feb 11, 2023
@mstv mstv merged commit 1e217cb into gitextensions:master Feb 12, 2023
@mstv mstv deleted the fix/silent_edit branch February 12, 2023 23:56
@mstv
Copy link
Member Author

mstv commented Feb 13, 2023

Sorry, this was a quick shot, which drops all cursor keys. I had not thoroughly retested after moving the code.
Accessing RichTextBox properties does not work in WndProc(WM_KEYDOWN) because most of the involved properties are implemented using SendMessage.

mstv added a commit that referenced this pull request Feb 13, 2023
@mstv
Revert "EditNetSpell: Avoid unhandled-key sound for cursor keys (#10715…
e872016 
…)"

This reverts commit 1e217cb.
mstv added a commit to mstv/gitextensions that referenced this pull request Feb 13, 2023
@mstv
Revert "EditNetSpell: Avoid unhandled-key sound for cursor keys (gite…
3c9e31e 
…xtensions#10715)"

This reverts commit 1e217cb.
@mstv mstv mentioned this pull request Feb 17, 2023
Merged
mstv added a commit that referenced this pull request Feb 22, 2023
@mstv
EditNetSpell: Avoid unhandled-key sound for cursor keys (#10730)
fc704e2 
* EditNetSpell: Avoid unhandled-key sound for cursor keys

using new TextBoxSilencer

* Revert "EditNetSpell: Avoid unhandled-key sound for cursor keys (#10715)"

This reverts commit 1e217cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@gerhardol gerhardol gerhardol approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstv @RussKie @gerhardol