Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStatusList: Create group also for orphan commit #10716

Merged
merged 1 commit into from Feb 12, 2023
Merged

FileStatusList: Create group also for orphan commit #10716

merged 1 commit into from Feb 12, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 11, 2023

Fixes #10694

Proposed changes

  • FileStatusList: Create a ListViewGroup for all commits including for orphan commits
    because of consistency and mainly because the text search implementation is based on groups

Screenshots

Before

image

After

image

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 879bc4f
  • Git 2.39.0.windows.1
  • Microsoft Windows NT 10.0.19045.0
  • .NET 6.0.12
  • DPI 96dpi (no scaling)
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Feb 11, 2023
@mstv mstv merged commit e35d144 into gitextensions:master Feb 12, 2023
@mstv mstv deleted the fix/i10694_orphan_commit branch February 12, 2023 23:56
@ghost ghost added this to the vNext milestone Feb 12, 2023
@gerhardol gerhardol mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[NBug] Object reference not set to an instance of an object.
2 participants
@mstv @RussKie