Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup splitter settings #10718

Merged
merged 2 commits into from Feb 12, 2023
Merged

Fixup splitter settings #10718

merged 2 commits into from Feb 12, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 12, 2023

Fixes splitter position not being restored correctly if CommitInfo is displayed "left of graph".

Proposed changes

  • Do not apply the workaround in FormBrowse.SetSplitterPositions if not necessary, i.e. if CommitInfo is displayed "left of graph"
  • SplitterManager: Also store Panel2Collapsed (generic issue)

Test methodology

  • manual with CommitInfo both "left of graph" and "right of graph"

Test environment(s)

  • Git Extensions 33.33.33
  • Build adf5184
  • Git 2.39.0.windows.1
  • Microsoft Windows NT 10.0.19045.0
  • .NET 6.0.12
  • DPI 96dpi (no scaling)
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Feb 12, 2023
gerhardol
gerhardol reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, not run

@mstv mstv merged commit 12fb7fa into gitextensions:master Feb 12, 2023
@mstv mstv deleted the fix/splittersettings branch February 12, 2023 23:55
@ghost ghost added this to the vNext milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol left review comments

@RussKie RussKie RussKie approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstv @RussKie @gerhardol