SidePanel: Disallow copy context for not visible stashes #10829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect info was copied.
ghost
assigned 
mstv
approved these changes
Mar 25, 2023
RussKie
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The information for the selected commit was used instead of the right clicked stash.
An alternative is to get the data from the rightclicked revision, but the copy uses IScriptHostControl that gets the copy from the revision grid, so this is a much bigger task.
Sidenote: The primary reason I am changing this is to make it simpler to investigate why "git-log --reflog" occasionally hides branches that "git-log --all" shows. No info there, it is Git that delivers this info...
Screenshots
Before
See Message matching the first stash
After
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.