Refactor and fixup graph loading #10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
Mar 29, 2023
|
This type has some great comments, but I feel like additional inline comments for the changed lines could further help. E.g., I find this very useful: gitextensions/GitUI/UserControls/RevisionGrid/Graph/RevisionGraph.cs Lines 428 to 448 in de93fd8 A specific example: in lines:100-101 we're now multiplying by 2 - why and what does it mean? |
RussKie
added
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
mstv
force-pushed
the
fix/graph_lookahead
branch
from
6faf40d
to
8f48e5b
Compare
mstv
commented
Mar 31, 2023
| @@ -458,36 +486,40 @@ static void StraightenLanes(int startIndex, int lastIndex, IList<RevisionGraphRo | |||
|
|
|||
| bool moved = false; | |||
| IRevisionGraphRow previousRow = localOrderedRowCache[currentIndex - 1]; | |||
| IRevisionGraphRow nextRow = localOrderedRowCache[currentIndex + 1]; | |||
There was a problem hiding this comment.
This was an unused leftover from the previous one-line straightening algorithm.
mstv
commented
Mar 31, 2023
| @@ -682,16 +683,19 @@ private async Task UpdateVisibleRowRangeInternalAsync() | |||
|
|
|||
| if (AppSettings.ShowRevisionGridGraphColumn) | |||
| { | |||
| int scrollTo; | |||
There was a problem hiding this comment.
a pointless copy of newBackgroundScrollTo
RussKie
approved these changes
Mar 31, 2023
gerhardol
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10680
Proposed changes
RevisionGraph.GetSegmentsForRow: Handle negativerowUpdateVisibleRowRangeInternalAsyncclearerStraightenLanesclearer (taken from Straighten revision graph in more cases #10778)Screenshots
N/A
Test methodology
Merge strategy
Please do not squash merge the commits!
✒️ I contribute this code under The Developer Certificate of Origin.