IScriptHostControl.CurrentBranch() to decrease overhead #10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurrentBranch is already calculated in RevisionGrid
|
If current branch is changed outside of current ge instance and you run, it will be wrong. Running the git command should be run to make sure of current branch. |
That applies to any change in the grid: commits, current branch etc, so this is even more consistent. You need to refresh if doing external changes. |
mstv
approved these changes
Apr 1, 2023
RussKie
added
the
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
mstv
reviewed
Apr 2, 2023
mstv
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Module.GetSelectedBranch() requires about 1 ms (15000 ticks) also if no Git command is required.
This info is already calculated in the revision grid and can be made available in the IScriptHostControl interface.
(An alternative is to add this to the event like for FilteredGitRefsProvider.)
Adding this in side panel, could be added elsewhere.
In for instance CommitInfo the reference to IScriptHostControl need to be provided after creation, so a few more steps.
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.