Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of git:// protocol in GitHub plugin #10871

Merged

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Apr 11, 2023

as it is no more supported by GitHub

https://github.blog/2021-09-01-improving-git-protocol-security-github/#when-are-these-changes-effective

Use ssh instead...

Fixes #10867

Depends on gitextensions/Git.hub#21

Test methodology

  • Not tested 😢 (as I don't use ssh). Hope that @djc5166 will be able to test it...

Test environment(s)

  • Git Extensions 33.33.33
  • Build 7dc4416 (Dirty)
  • Git 2.40.0.windows.1
  • Microsoft Windows NT 10.0.22621.0
  • .NET 6.0.15
  • DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned pmiossec Apr 11, 2023
@gerhardol
Copy link
Member

PR for GitHub submodule first please... (that change is fine for me)

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
But submodule to be updated first

@pmiossec pmiossec force-pushed the remove_git_protocol_support branch from 7dc4416 to 4daf9d7 Compare April 12, 2023 11:57
@pmiossec pmiossec force-pushed the remove_git_protocol_support branch from 4daf9d7 to b1c9fb7 Compare April 12, 2023 12:49
@pmiossec
Copy link
Member Author

@djc5166 Can you test the portable version for this fix and confirm that it is working well for you? It's there: https://ci.appveyor.com/project/gitextensions/gitextensions/builds/46764408/artifacts

@djc5166
Copy link

djc5166 commented Apr 12, 2023

@djc5166 Can you test the portable version for this fix and confirm that it is working well for you? It's there: https://ci.appveyor.com/project/gitextensions/gitextensions/builds/46764408/artifacts

Works, thanks for the fix.

@pmiossec
Copy link
Member Author

Works, thanks for the fix.

Thanks for the test 😉

@pmiossec pmiossec merged commit 7953832 into gitextensions:release/4.1 Apr 12, 2023
3 checks passed
@pmiossec pmiossec deleted the remove_git_protocol_support branch April 12, 2023 14:38
@RussKie RussKie added this to the 4.1 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants