No async when minimized #10880
Merged
No async when minimized #10880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run git-ls-files by default when in minimized to not interfere with restoring. The setting was added in cccfbc9 but required explicit configuration.
ghost
assigned 
|
I guess your branch "feature/i9223-async-conflict" is the reason why this bug does not occur to me. |
Maybe. The problem mostly fixed in #10802 was not new, it had supposedly occasionally occurred for many years. |
RussKie
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Do not run git-ls-files by default when in minimized to not interfere with restoring.
The setting was added in
cccfbc9 (#10847)
but required explicit configuration.
--
I have used this on/off for some days and get quite consistent the problem with the default implementation.
The drawback with activating the setting is that "is conflicted" is not always detected.
The drawback of making this hack permanent is that the core problem will not be fixed.
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.