Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English.xlf #10889

Closed
wants to merge 1 commit into from
Closed

Update English.xlf #10889

wants to merge 1 commit into from

Conversation

1Jesper1
Copy link

Fix labels

Fixes #

Proposed changes

Screenshots

Before

After

Test methodology

Test environment(s)

  • GIT
  • Windows

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@pmiossec
Copy link
Member

This file is generated so it is not the right way to fix it as your changes will be overwritten (and the build will not pass so not chance it will be merged)...

@gerhardol
Copy link
Member

The text is used for menu items where the keyboard accelrator is used as well as for tooltips.
Either the label is duplicated or the label is 'cleaned' before being added as a ToolTip (maybe a hack but the least effort for everyone).

As pmiossec wrote: Must be changed in the .cs files.

@pmiossec
Copy link
Member

I think we already fixed it somewhere for simple toolbar button but I can't find where anymore. For example for "File Explorer", in v4.1 it's fixed. But not for the split button subitems tooltips....

@pmiossec
Copy link
Member

pmiossec commented Apr 17, 2023

So partly done in v4.1 here: #10781 (I thought it have been done automatically but in fact, it was manual)

@1Jesper1
Copy link
Author

@pmiossec Nice, also this one?
image

@pmiossec pmiossec closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants