Some recent repositories settings improvements #10903

pmiossec · 2023-04-21T08:37:44Z

I have selected only the accepted and already reviewed commit of #3769 to see some improvements made for v4.1

Note: Small commits that are easily reviewed one by one.

Configure repositories popup:

Being able to see the repository selected in the lists
Being able to do an action on multiple repositories at the same time
Resize column size to prevent bad display (when destination list was initially empty or changing shortening strategy)
Display 'Anchored' repositories in bold
Show full path in a tooltip
Display unavailable/deleted repositories in red
Double click to transfer a repository from one list to the other

Repositories list:

Always display a separator between pinned and all recent repositories

Screenshots

Configuration

Before

After

Test methodology

Manual

Test environment(s)

Git Extensions 33.33.33
Build 29515dc
Git 2.40.0.windows.1
Microsoft Windows NT 10.0.22621.0
.NET 6.0.16
DPI 96dpi (no scaling)
Microsoft.WindowsDesktop.App Versions

    Microsoft.WindowsDesktop.App 6.0.15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.16 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 7.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer "Merge commit" (better) or "Rebase merge" this PR.

✒️ I contribute this code under The Developer Certificate of Origin.

pmiossec · 2023-04-21T08:47:05Z

I do not want to delay 4.1 any more...

As I said, I really want to see a beginning of improvements on this form included in the next release.
That's why I have selected just the small changes that introduce mostly UI improvements that could easily be review (one by one) and tested (and that introduce no translation modifications).
But in the end, I let you decide if you want include it or not (and to merge it).

RussKie

+0

mstv

appears sensible to me

GitUI/CommandsDialogs/BrowseDialog/FormRecentReposSettings.cs

gerhardol

+0
Changes seem fine to me but not run and no deep review.
(and pmiossec, I am not innocent of delaying releases myself, but I want the normal update to start so we can get a 4.2 out).

RussKie · 2023-04-28T08:39:25Z

@mstv's comments are still unresolved.

RussKie · 2023-04-30T04:14:48Z

@pmiossec could you please resolve the outstanding feedback - action or reject - so that we could merge this. This seems to be the last outstanding item tagged for v4.1. Thanks

when: - destination list was initially empty - changing shortening strategy

+ refactoring

I don't see a good reason to display the separator only when a one of the list is sorted.

pmiossec · 2023-04-30T07:45:58Z

@pmiossec could you please resolve the outstanding feedback - action or reject - so that we could merge this. This seems to be the last outstanding item tagged for v4.1. Thanks

Done.

mstv · 2023-04-30T09:15:31Z

GitUI/CommandsDialogs/BrowseDialog/FormRecentReposSettings.cs

                AllRecentLB.BeginUpdate();

                SetComboWidth();
-                RefreshRepos();
            }
            finally
            {


PinnedLB.BeginUpdate(); AllRecentLB.BeginUpdate();

seems to be not necessary here any longer.
Though it should be added to RefreshRepos().

done (With a little bonus: improvement over the bad UX of the "Combobox minimum width" that I had to use for the 1st time to test this piece of code)

mstv · 2023-04-30T14:22:26Z

GitUI/CommandsDialogs/BrowseDialog/FormRecentReposSettings.cs

@@ -35,6 +37,7 @@ private void LoadSettings()
            SetNumericUpDownValue(_NO_TRANSLATE_maxRecentRepositories, AppSettings.MaxPinnedRepositories);
            SetNumericUpDownValue(_NO_TRANSLATE_RecentRepositoriesHistorySize, AppSettings.RecentRepositoriesHistorySize);

+            _previousValue = comboMinWidthEdit.Value;


Suggested change

_previousValue = comboMinWidthEdit.Value;

_previousValue = comboMinWidthEdit.Value;

return;

by jumping directly to values that has an effects i.e 0 to 30 (values between 1 and 30 will have the same effect than 30) Prevent the user to have to click 30 times on a up or down buttons to see an effect.

ghost assigned pmiossec Apr 21, 2023

RussKie approved these changes Apr 22, 2023

View reviewed changes

RussKie added this to the 4.1 milestone Apr 22, 2023

mstv reviewed Apr 22, 2023

View reviewed changes

gerhardol reviewed Apr 22, 2023

View reviewed changes

gerhardol approved these changes Apr 26, 2023

View reviewed changes

RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Apr 28, 2023

RussKie changed the base branch from release/4.1 to release/4.0 April 30, 2023 06:27

pmiossec added 8 commits April 30, 2023 09:41

Being able to see the repository selected in the lists

5ee52bd

Being able to do an action on multiple repositories at the same time

00dad8d

Resize column size to prevent bad display

a1dfeac

when: - destination list was initially empty - changing shortening strategy

Display 'Anchored' repositories in bold

b0fe274

Show tooltips containing the full path of repositories

9217d00

+ refactoring

Display deleted or unavailable repositories in red

ee19d37

Always display a separator between pinned and all recent repositories

6e0bfc5

I don't see a good reason to display the separator only when a one of the list is sorted.

Double click on a list item move it in other list

432e5a7

pmiossec force-pushed the recent_repositories_settings_improvements branch from 004a776 to 432e5a7 Compare April 30, 2023 07:45

ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Apr 30, 2023

mstv reviewed Apr 30, 2023

View reviewed changes

Move BeginUpdate() / EndUpdate() in a better place (in RefreshRepos())

84fca74

mstv approved these changes Apr 30, 2023

View reviewed changes

Better UX for combobox minimum width

92a1d0e

by jumping directly to values that has an effects i.e 0 to 30 (values between 1 and 30 will have the same effect than 30) Prevent the user to have to click 30 times on a up or down buttons to see an effect.

pmiossec force-pushed the recent_repositories_settings_improvements branch from ff2b1df to 92a1d0e Compare April 30, 2023 14:25

RussKie merged commit ea3445d into gitextensions:release/4.0 Apr 30, 2023
5 checks passed

pmiossec deleted the recent_repositories_settings_improvements branch April 30, 2023 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some recent repositories settings improvements #10903

Some recent repositories settings improvements #10903

pmiossec commented Apr 21, 2023

pmiossec commented Apr 21, 2023 •

edited

RussKie left a comment

mstv left a comment

gerhardol left a comment

RussKie commented Apr 28, 2023

RussKie commented Apr 30, 2023

pmiossec commented Apr 30, 2023

mstv Apr 30, 2023

pmiossec Apr 30, 2023

mstv Apr 30, 2023

pmiossec Apr 30, 2023

Some recent repositories settings improvements #10903

Some recent repositories settings improvements #10903

Conversation

pmiossec commented Apr 21, 2023

Screenshots

Configuration

Before

After

Menu

Before

After

Test methodology

Test environment(s)

Merge strategy

pmiossec commented Apr 21, 2023 • edited

RussKie left a comment

Choose a reason for hiding this comment

mstv left a comment

Choose a reason for hiding this comment

gerhardol left a comment

Choose a reason for hiding this comment

RussKie commented Apr 28, 2023

RussKie commented Apr 30, 2023

pmiossec commented Apr 30, 2023

mstv Apr 30, 2023

Choose a reason for hiding this comment

pmiossec Apr 30, 2023

Choose a reason for hiding this comment

mstv Apr 30, 2023

Choose a reason for hiding this comment

pmiossec Apr 30, 2023

Choose a reason for hiding this comment

pmiossec commented Apr 21, 2023 •

edited