Intercept and convert \\wsl.localhost\ to \\wsl$\ paths

[RussKie]

Resolves #10025
Resolves #10815

Test methodology

• manual
• unit tests

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

---

✒️ I contribute this code under The Developer Certificate of Origin.

[vbjay]

Should this be an exe.config thing? Allow for the matches to be defined and the replacement.

[mstv]

just doc typos, have not run

[gerhardol]

Have run very briefly.
I believe this is all that is needed, took a quick look at the implementation.

This will display recent (and current) repos opened as wsl.localhost as wsl$. From a usability view, that is better as the recents are not duplicated. Users may be confused though.
(It is also much simpler to implement it this way.)

I will update the doc.

This feature was something I considered to, as wslpath returns wsl.locahost and then you get the extra item.
I decided to not delay 4.1 for this, but have no problem accepting changes from someone else.

[RussKie]

Should this be an exe.config thing? Allow for the matches to be defined and the replacement.

I'm not sure what you mean, sorry.

[RussKie]

Users may be confused though.

Perhaps, but looks like users get confused by "wsl.localhost" more.

[vbjay]

Should this be an exe.config thing? Allow for the matches to be defined and the replacement.

I'm not sure what you mean, sorry.

If wsl decides to change aliases or if user can change it to something else. Thinking if they needs to fix we can at least tell them to change the config file to allow it to work till we make a release.

[RussKie]

Should this be an exe.config thing? Allow for the matches to be defined and the replacement.

I'm not sure what you mean, sorry.

If wsl decides to change aliases or if user can change it to something else. Thinking if they needs to fix we can at least tell them to change the config file to allow it to work till we make a release.

These are Windows defined, so I don't expect these to change often.

[gerhardol]

Users may be confused though.

Perhaps, but looks like users get confused by "wsl.localhost" more.

There will be issues with users claiming that wsl.localhost is the new name and that it should be used instead of the old name, or that the entered name is used.
I prefer this solution, just wanted to point that out. i prefer this way:

• A solution where the entered name is used will be more complex and may get two entries in the recent list.
• We could translate to wsl.localhost instead, for users with wsl 1.0 or later. That will require a check for older version (either translate differently or use Windows Git). wsl$ is a shorter prefix too.

These are Windows defined, so I don't expect these to change often.

wsl$ was changed just because it contains illegal characters, requiring special handling. I would not expect this to be changed again.
There are some special handling to wsl handling, like file notification is not working. So wsl is a special handling.

*Nix users (with wine or so) may need a similar "mode, triggered on something else.

[andrej-schaefer]

I see a problem with this solution for the following use case:
Use WSL for DEV and runtime, for this purpose code is in the WSL file system
Use wsl.localhost for gitExtensions due to use putty and configure different ssh keys per project / customer with a passphrase

With the new solution it change to wsl and does not take the configured ssh in gitExtensions any more but redirects to default ssh in WSL

Workaround is to downgrade of gitExtensions or move repos to windows
Easy solution to handle multiple ssh files on linux i havent found so far, maybe someone have a solution for this problem
Propose is complex, maybe select in the repository selection or some kind of configuration
Hope this comment is ok, if not, please let me know :)

WSL: WSL 2 with latet ubuntu
Windows 11

[gerhardol]

Git repos mapped to a drive letter will not use the special WSL handling but Windows Git

From https://git-extensions-documentation.readthedocs.io/en/release-4.1/settings.html#wsl-git-notes
(will modify the formatting)

There are too many settings in GE already, I would like to avoid more (there are some hidden settings for WSL, not related to this though).

Originally, I wanted to have wsl.localhost separated as you describe, but Windows insists on wsl.localhost in most conversions so it it inconvenient...