Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode url-encoded repository folder's name #10920

Merged
merged 1 commit into from Apr 27, 2023
Merged

Decode url-encoded repository folder's name #10920

merged 1 commit into from Apr 27, 2023

Conversation

montoner0
Copy link
Contributor

Fixes #10919

Proposed changes

  • Decode the part with the repository name for URLs but not local paths. Not quite sure though if ssh:// and git@ links are considered as URL-encoded (can't find info).

Screenshots

Before

image

After

image

Test methodology

Test environment(s)

  • Git 2.40.1.windows.1
  • Microsoft Windows NT 10.0.19045.0

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned montoner0 Apr 27, 2023
RussKie
RussKie approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@RussKie RussKie merged commit 23caefd into gitextensions:master Apr 27, 2023
4 checks passed
@ghost ghost added this to the vNext milestone Apr 27, 2023
RussKie pushed a commit that referenced this pull request Apr 27, 2023
@montoner0 @RussKie
Decode url-encoded repository folder's name (#10920)
4456eec 
(cherry picked from commit 23caefd)
@RussKie RussKie modified the milestones: vNext, 4.1 Apr 27, 2023
@montoner0 montoner0 deleted the fix_url_decode branch April 28, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@montoner0 montoner0

Labels
🖊️ status: cla signed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

URL-encoded link to a repository isn't decoded for a cloned folder name
2 participants
@montoner0 @RussKie