Replace sync CommitMessageManager API with async #10930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
force-pushed
the
async_ICommitMessageManager
branch
from
7f79ac2
to
a2e9d91
Compare
Resolves gitextensions#10926 The use of sync API leads to observable delays and locking the application when working with repos located in WSL.
RussKie
force-pushed
the
async_ICommitMessageManager
branch
from
a2e9d91
to
9fa59a2
Compare
mstv
reviewed
Apr 30, 2023
Co-authored-by: Michael Seibt <36601201+mstv@users.noreply.github.com>
Co-authored-by: Michael Seibt <36601201+mstv@users.noreply.github.com>
Co-authored-by: Michael Seibt <36601201+mstv@users.noreply.github.com>
RussKie
commented
Apr 30, 2023
RussKie
commented
Apr 30, 2023
RussKie
commented
Apr 30, 2023
mstv
approved these changes
Apr 30, 2023
|
Thank you |
RussKie
added a commit
to RussKie/gitextensions
that referenced
this pull request
May 2, 2023
Merged
RussKie
added a commit
that referenced
this pull request
May 3, 2023
* Before packaging check if all files in $(PublishDir) are delcared in Setup/Product.wxs * Add missing assemblies Addendum to #10930
dimfishr
pushed a commit
to dimfishr/gitextensions
that referenced
this pull request
May 5, 2023
* Before packaging check if all files in $(PublishDir) are delcared in Setup/Product.wxs * Add missing assemblies Addendum to gitextensions#10930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10926
The use of sync API leads to observable delays and locking
the application when working with repos located in WSL.
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.