Handle all message filters starting with -- as git-log options #10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar handling as gitextensions#10832 for branch box
ghost
assigned 
mstv
approved these changes
May 5, 2023
| @@ -1183,10 +1183,10 @@ string GetFilterRefName(string gitRef) | |||
|
|
|||
| [TestCase("message1", true)] | |||
| [TestCase("message1 --not", true)] | |||
| [TestCase("--not=message1", true)] | |||
| [TestCase("--not=message1", false)] | |||
| [TestCase("--not message1", false)] | |||
| [TestCase(" --not message1", true)] | |||
There was a problem hiding this comment.
Is this intended? Else .TrimLeft().StartsWith("--")?
There was a problem hiding this comment.
(unchanged from before)
The message to search for is not trimmed, initial and trailing whitespace is searched for.
| [TestCase("--not message1", false)] | ||
| [TestCase(" --not message1", true)] | ||
| [TestCase("--exclude message1", true)] | ||
| [TestCase("--exclude message1", false)] | ||
| [TestCase("--exclude= message1", false)] | ||
| [TestCase("--exclude= message1 ", false)] | ||
| [TestCase("\t--exclude= message1", true)] |
RussKie
pushed a commit
that referenced
this pull request
May 6, 2023
Co-authored-by: Gerhard Olsson <gerhardol@users.noreply.github.com> (cherry picked from commit 9f84f6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar handling as #10832 for branch box
Proposed changes
#10240 handles "--not ", "--exclude=" as options, this aligns with #10832
To be considered for 4.1
Test methodology
Tests updated.
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.