Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some missing NotNullWhen #11007

Merged
merged 2 commits into from Jun 1, 2023
Merged

add some missing NotNullWhen #11007

merged 2 commits into from Jun 1, 2023

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@ghost ghost assigned SimonCropp May 31, 2023
@RussKie
Copy link
Member

RussKie commented May 31, 2023 via email •
edited by ghost

@SimonCropp
Copy link
Contributor Author

@RussKie so in this case; is the type obvious?

@mstv
Copy link
Member

mstv commented May 31, 2023

so in this case; is the type obvious?

No, it is not.

mstv
mstv approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo use of var

@RussKie
Copy link
Member

RussKie commented Jun 1, 2023

Thank you

@RussKie RussKie merged commit 778e510 into gitextensions:master Jun 1, 2023
4 checks passed
@ghost ghost added this to the vNext milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol left review comments

@RussKie RussKie RussKie approved these changes

@mstv mstv mstv approved these changes

Assignees

@SimonCropp SimonCropp

Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonCropp @RussKie @mstv @gerhardol