Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: Ignore Git exceptions for git-status by file #11031

Merged

Conversation

gerhardol
Copy link
Member

Follow up to #11030

Proposed changes

These changes will occur over and over again at
for instance file access problems and can therefore not be dismissed.

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

These changes will occur over and over again at
for instance file access problems and can therefore not be dismissed.
@ghost ghost assigned gerhardol Jun 7, 2023
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.5 ;-)

GitUI/AutoCompletion/CommitAutoCompleteProvider.cs Outdated Show resolved Hide resolved
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 9, 2023
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 9, 2023
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.5 ;-) (1/2 because of error hiding in a less important feature)

@gerhardol
Copy link
Member Author

+0.5 ;-) (1/2 because of error hiding in a less important feature)

I see your point, but errors here gives a popup that cannot be dismissed (as it pops up immediately).
I did not bother with a conditional popup, only occurring once.
This can be improved.

@gerhardol gerhardol merged commit e38b8ca into gitextensions:master Jun 9, 2023
3 of 4 checks passed
@gerhardol gerhardol deleted the feature/i11029-trycatch-autocomplete branch June 9, 2023 19:58
@ghost ghost added this to the vNext milestone Jun 9, 2023
@mstv mstv mentioned this pull request Jun 12, 2023
@RussKie RussKie linked an issue Jun 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NBug]
3 participants