New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tamil Config and Translation files updated #11042
Conversation
Added only Tamil config file and the translation file.
Flag still needed |
The setup configurations must be updated for the build to pass:
diff --git a/Setup/Product.wxs b/Setup/Product.wxs
index 91aaa62c0..122ba3fd6 100644
--- a/Setup/Product.wxs
+++ b/Setup/Product.wxs
@@ -526,6 +526,15 @@
<Component Id="Spanish.Plugins.xlf" Guid="*">
<File Source="$(var.ArtifactsPublishPath)\Translation\Spanish.Plugins.xlf" />
</Component>
+ <Component Id="Tamil.gif" Guid="*">
+ <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.gif" />
+ </Component>
+ <Component Id="Tamil.xlf" Guid="*">
+ <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.xlf" />
+ </Component>
+ <Component Id="Tamil.Plugins.xlf" Guid="*">
+ <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.Plugins.xlf" />
+ </Component>
<Component Id="TraditionalChinese.gif" Guid="*">
<File Source="$(var.ArtifactsPublishPath)\Translation\Traditional Chinese.gif" />
</Component>
@@ -844,6 +853,11 @@
<ComponentRef Id="Spanish.Plugins.xlf" />
<ComponentRef Id="Spanish.gif" />
</Feature>
+ <Feature Id="Tamil" Title="Tamil" Level="1">
+ <ComponentRef Id="Tamil.xlf" />
+ <ComponentRef Id="Tamil.Plugins.xlf" />
+ <ComponentRef Id="Tamil.gif" />
+ </Feature>
<Feature Id="TraditionalChinese" Title="Traditional Chinese" Level="1">
<ComponentRef Id="TraditionalChinese.xlf" />
<ComponentRef Id="TraditionalChinese.Plugins.xlf" /> Run: pushd .\.tools\transifex\
.\DownloadTransifexTranslations.ps1
popd
git stage Setup/Product.wxs |
updated the product.wxs file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the result of the script execution |
sorted alphabetically ascending order
Feature ID - sorted
Sorted the file content with two more commits. You can find the diff is clean with only addition of Tamil file entries. |
Added only Tamil config file and the translation file.
Fixes #
Proposed changes
Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.