Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tamil Config and Translation files updated #11042

Merged
merged 5 commits into from Jun 15, 2023
Merged

Conversation

TamilNeram
Copy link
Contributor

Added only Tamil config file and the translation file.

Fixes #

Proposed changes

Screenshots

Before

After

Test methodology

Test environment(s)

  • GIT
  • Windows

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Added only Tamil config file and the translation file.
@ghost ghost assigned TamilNeram Jun 12, 2023
@gerhardol
Copy link
Member

Flag still needed

@TamilNeram
Copy link
Contributor Author

Tamil
Tamil universal flag

@RussKie
Copy link
Member

RussKie commented Jun 13, 2023

The setup configurations must be updated for the build to pass:

  [ERROR] Items not declared in Product.wxs:
  	C:\projects\gitextensions\artifacts\Release\publish\GitExtensions\Translation\Tamil.gif
  	C:\projects\gitextensions\artifacts\Release\publish\GitExtensions\Translation\Tamil.Plugins.xlf
  	C:\projects\gitextensions\artifacts\Release\publish\GitExtensions\Translation\Tamil.xlf
C:\projects\gitextensions\GitExtensions\Project.Publish.targets(218,5): error MSB3073: The command "..." exited with code 1. [C:\projects\gitextensions\GitExtensions\GitExtensions.csproj]
diff --git a/Setup/Product.wxs b/Setup/Product.wxs
index 91aaa62c0..122ba3fd6 100644
--- a/Setup/Product.wxs
+++ b/Setup/Product.wxs
@@ -526,6 +526,15 @@
       <Component Id="Spanish.Plugins.xlf" Guid="*">
         <File Source="$(var.ArtifactsPublishPath)\Translation\Spanish.Plugins.xlf" />
       </Component>
+      <Component Id="Tamil.gif" Guid="*">
+        <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.gif" />
+      </Component>
+      <Component Id="Tamil.xlf" Guid="*">
+        <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.xlf" />
+      </Component>
+      <Component Id="Tamil.Plugins.xlf" Guid="*">
+        <File Source="$(var.ArtifactsPublishPath)\Translation\Tamil.Plugins.xlf" />
+      </Component>
       <Component Id="TraditionalChinese.gif" Guid="*">
         <File Source="$(var.ArtifactsPublishPath)\Translation\Traditional Chinese.gif" />
       </Component>
@@ -844,6 +853,11 @@
           <ComponentRef Id="Spanish.Plugins.xlf" />
           <ComponentRef Id="Spanish.gif" />
         </Feature>
+        <Feature Id="Tamil" Title="Tamil" Level="1">
+          <ComponentRef Id="Tamil.xlf" />
+          <ComponentRef Id="Tamil.Plugins.xlf" />
+          <ComponentRef Id="Tamil.gif" />
+        </Feature>
         <Feature Id="TraditionalChinese" Title="Traditional Chinese" Level="1">
           <ComponentRef Id="TraditionalChinese.xlf" />
           <ComponentRef Id="TraditionalChinese.Plugins.xlf" />

Run:

pushd .\.tools\transifex\
.\DownloadTransifexTranslations.ps1
popd
git stage Setup/Product.wxs

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 13, 2023
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 13, 2023
@TamilNeram
Copy link
Contributor Author

updated the product.wxs file

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup/Product.wxs Outdated Show resolved Hide resolved
@RussKie
Copy link
Member

RussKie commented Jun 13, 2023

updated the product.wxs file

That's not the result of the script execution

sorted alphabetically  ascending order
Feature ID - sorted
@TamilNeram
Copy link
Contributor Author

Sorted the file content with two more commits. You can find the diff is clean with only addition of Tamil file entries.

@mstv mstv merged commit 928983a into gitextensions:master Jun 15, 2023
4 checks passed
@ghost ghost added this to the vNext milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants