Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check output of every git command when exit code is different than 0 #11062

Merged

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Jun 19, 2023

to check if it's not due to security issue

Fixes #10816, Fixes #10975, Fixes #11027, Fixes #11039

Improvement on security issue over what has been already done in #10436

Screenshots

Before

image

After

image

Test methodology

  • Manual (For FormCommit and FormPull)

Test environment(s)

  • Git Extensions 33.33.33
  • Build bcbc3dd
  • Git 2.40.0.windows.1 (recommended: 2.40.1 or later)
  • Microsoft Windows NT 10.0.22621.0
  • .NET 6.0.16
  • DPI 96dpi (no scaling)
  • Portable: False
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.16 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 7.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned pmiossec Jun 19, 2023
@pmiossec
Copy link
Member Author

pmiossec commented Jun 19, 2023

A better fix than #11055 because it also fixes #10816 ... (i.e. working for all forms started directly with gitex command line options)

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run

GitCommands/Git/ExecutableExtensions.cs Outdated Show resolved Hide resolved
@RussKie
Copy link
Member

RussKie commented Jun 21, 2023

Possibly fix #11064 too?

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 21, 2023
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 21, 2023
@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 21, 2023
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 21, 2023
@RussKie RussKie merged commit 9e86ad3 into gitextensions:master Jun 21, 2023
4 checks passed
@ghost ghost added this to the vNext milestone Jun 21, 2023
@pmiossec pmiossec deleted the better_fix_security_issue_detection branch June 22, 2023 11:17
@pmiossec pmiossec mentioned this pull request Jul 3, 2023
@pmiossec pmiossec mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants