New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/i11054 clean submodules #11101
Feature/i11054 clean submodules #11101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview is not handled in Preview_Click()
I suggest that is added too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NatRavenhill and @scottsumrall can you agree how to merge the Designer changes?
I'm fairly new to this but happy to give it a shot. Would it possibly be easier to just revert my designer and modify based on what @NatRavenhill has? The UI wasn't particularly difficult to implement in the first place. Seems like merging the designer files could be problematic but it's not something I've really messed with before. |
The PR that goes second need to rebase on master using the Designer file from master and then manually reapply changes. Not so hard but often feeling like a waste of time. But hard to avoid here. |
Works for me |
Pushed a change for ArgumentString as well as for using common code for preview/execute. |
Thank you all |
Fixes #11054
Proposed changes
Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.