#11108 Disabled hotkeys in scenarios where their usage was not intended

[IlijaQ]

Fixes #11108

Proposed changes

• Creating a new branch using hotkeys Ctrl + B does not prompt FromCreateBranch while in bare repository, neither when artificial commit is selected.
• While selecting multiple commits, hotkey for creating new branch is disabled
• Rebasing current branch using hotkeys Ctrl + Shift + E is disabled while artificial commit is selected
• Creating a new tag using hotkeys Ctrl + T is disabled while artificial commit is selected

Test methodology

• Manual with GE repo

Test environment(s)

• Git Extensions 33.33.33
• Build 8b5eab5
• Git 2.30.0.windows.2 (recommended: 2.40.1 or later)
• Microsoft Windows NT 10.0.19045.0
• .NET 6.0.14
• DPI 120dpi (125% scaling)

[gerhardol]

Most similar issues should be handled by the check in the method returns false when conditions are not fulfilled (the action could be handled by another form then). This should be done here too.
I will not oppose a merge though, if another maintainer approves.

I am sure there are several other similar issues still even if several similar issues exists...

[IlijaQ]

Yes, I have tried that. When the method returns false, the hotkey is passed to the context menu. Every time we open the context menu for the selected commit, it checks if create branch action or some other action should be enabled, but that is to late.

The problem is when we select a regular commit, right click, and then select an artificial commit - without right clicking on the artificial commit, and press the hotkey, we can still cause this bug.

If you are still in favor of passing the action handling to another form, we may want to add a double redundant validation in context menu click event handeling or change the context menu to perform update of Enabled propery of all context menu items every time a new commit is selected.

[gerhardol]

I just want to move the logic ti the method handling the request, not in ExecuteCommand().
This is how all other hot keys are handled.

[IlijaQ]

Ok,
Just in case, please specify the method where we want to move the validations to. Do we want to move the validations to the corresponding method in the switch statement? e.g. in case Command.CreateBranch: should we move the validation to StartCreateBranchDialog?

[IlijaQ]

@gerhardol I have updated the code for your review, according to your suggestions.

[gerhardol]

Approved with two suggested changes.
Changing from draft.

[gerhardol]

Suggested change

	if (Module.IsBareRepository() || (objectId is not null && objectId.IsArtificial))
	if (Module.IsBareRepository() || objectId?.IsArtificial is true)

[IlijaQ]

Hi, @gerhardol
I have implemented the changes that you suggested and rebased my branch to the latest develop. Can you reapprove this pull request?

[IlijaQ]

Sorry, my bad. I missed the question marks in my last commit. It should pass the build now.
It needs one more approval.
I apologize.

[RussKie]

Thank you!