Update cherrypick dialog #11158
Update cherrypick dialog #11158
Conversation
ghost
assigned 
Thank you. I plan to merge this in the next few days, unless there are objections. I'm currently doing a lot (and I mean a lot) of rebasing and cherry-picking. |
| } | ||
|
|
||
| private void SaveSettings() | ||
| { | ||
| AppSettings.CommitAutomaticallyAfterCherryPick = AutoCommit.Checked; | ||
| AppSettings.AddCommitReferenceToCherryPick = checkAddReference.Checked; | ||
| if (DialogResult == DialogResult.OK) |
There was a problem hiding this comment.
I would not add this condition. If changed, the user has clicked the CheckBoxes.
Sometimes, I need to close a dialog in order to lookup a detail and come back...
There was a problem hiding this comment.
Closing the dialog is essentially aborting the process. In this case, it doesn't feel right to retain the selection.
I didn't realise that I had those accidentally swapped. I'll change the order. Thanks |
|
Fixed: |
Proposed changes
GitExtensionsDialogand update the layout.Screenshots
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.