Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid always caught exception for unset settings #11159

Merged
merged 1 commit into from Aug 20, 2023
Merged

Avoid always caught exception for unset settings #11159

merged 1 commit into from Aug 20, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Aug 17, 2023

Proposed changes

  • Do not try to invoke a TypeConverter for null in Settings.GetValue()

Screenshots

N/A

Test methodology

  • existing tests

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Aug 17, 2023
@RussKie RussKie merged commit 027e83a into gitextensions:master Aug 20, 2023
4 checks passed
@ghost ghost added this to the vNext milestone Aug 20, 2023
@mstv mstv deleted the fix/settings_exception branch August 20, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstv @RussKie