Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditNetSpell: Avoid ObjectDisposedException #11160

Merged
merged 1 commit into from Aug 21, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Aug 17, 2023

Proposed changes

  • Avoid ObjectDisposedException by binding a local variable instead of this in async lambda
  • Remove unnecessary LINQ calls

Screenshots

N/A

Test methodology

  • existing tests
  • manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

and remove unnecessary LINQ calls
@mstv mstv self-assigned this Aug 17, 2023
@mstv mstv merged commit 7e00ab2 into gitextensions:master Aug 21, 2023
4 checks passed
@mstv mstv deleted the fix/spelling_cancellation branch August 21, 2023 17:23
@ghost ghost added this to the vNext milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants