Avoid and cope with exceptions on graph reload #11167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
Aug 21, 2023
| { | ||
| localOrderedRowCache = new List<RevisionGraphRow>(capacity: Math.Max(currentRowIndex, lastOrderedNodeIndex) + 1); |
There was a problem hiding this comment.
So currentRowIndex is always smaller than lastOrderedNodeIndex?
There was a problem hiding this comment.
No, this was a wrong shortcut. Reverted.
RussKie
approved these changes
Aug 24, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11166
Might fix #10957
Proposed changes
BackgroundUpdater.WrappedOperationAsync(): Avoid getting stuck on exception by addingtry finallyRevisionGraph.IsRowCacheDirty(): Safer detection by adding an additional check; rename for clarityRevisionGraph.CacheTo()from single context onlyScreenshots
N/A
Test methodology
Please do not squash merge
✒️ I contribute this code under The Developer Certificate of Origin.