Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct interface of JContainer for indexer #11169

Merged
merged 1 commit into from Aug 23, 2023

Conversation

mstv
Copy link
Member

@mstv mstv commented Aug 22, 2023

Fixes regression from #11141: System.ArgumentException: 'Accessed JArray values with invalid key value: ^1. Int32 array index expected.'

Proposed changes

  • Use the correct interface IList implemented by JContainer in order to be able to use the new style of array indexing "[^1]"

Screenshots

more than one build result in grid again

Test methodology

  • manually

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

fixup! Replace more LINQ First/Last with indexer (gitextensions#11141)
@mstv mstv added the type: regression regression, normally to latest official release label Aug 22, 2023
@mstv mstv self-assigned this Aug 22, 2023
@mstv mstv merged commit a081c61 into gitextensions:master Aug 23, 2023
4 checks passed
@mstv mstv deleted the fix/jarray_indexer branch August 23, 2023 19:47
@ghost ghost added this to the vNext milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression regression, normally to latest official release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants