Revision reader tweak #11170
Merged
Revision reader tweak #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid replace \v in email etc Make revision reading slightly easier to read.
RussKie
reviewed
Aug 24, 2023
| } | ||
|
|
||
| public (string? subject, string? body, bool hasMultiLineMessage) PeekSubjectBody(bool skipBody) | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] |
There was a problem hiding this comment.
How did you decide this attribute is necessary?
There was a problem hiding this comment.
This routine can be executed 100K every time the revisions are reloaded, so speed is preferred over code size
I considered removing the internal class StringLineReader to give the compiler some more hints.
I doubt this is measurable though.
RussKie
added
the
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
RussKie
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Avoid replace \v in email etc (not needed, performance).
Make revision reading slightly easier to read.
IDE0008 in RevisionReader.cs
This originated as a review to see if it was possible to improve the performance, primarily to see if allocations could be eliminated, but it does not seem there is big difference.
Still, this is critical code when opening repos.
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.