RevisionReader: No reflog for notes #11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mstv
approved these changes
Oct 1, 2023
Updated some more. |
RussKie
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Regression in #11225
Reflog selector identifies stashes and only listed with git-stash-list. However, the reflogselector can still be empty occasionally also in this situation for instance when Git Notes are displayed. These empty reflog selectors should not be presented as stashes.
For efficiency reasons the test is only for null values, i.e. empty reflog selectors must be presented as null. (In addition, a string should not be allocated even if string interning should eliminate the allocation need, there is still overhead).
https://github.com/gitextensions/gitextensions/blob/master/Plugins/GitUIPluginInterfaces/GitRevision.cs#L111
Test methodology
Test adjusted
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.