Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for skip worktree together with assume unchanged #11243

Merged

Conversation

gerhardol
Copy link
Member

Proposed changes

#11011 (comment)

Used in FormCommit

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Oct 4, 2023
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a regression test?

@gerhardol gerhardol marked this pull request as draft October 5, 2023 06:44
@gerhardol gerhardol marked this pull request as ready for review October 5, 2023 19:25
@gerhardol
Copy link
Member Author

Is it possible to add a regression test?

There are no previous tests, I do not think it is worth it. This would be a very exotic issue.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have not run

@RussKie RussKie merged commit e558ca1 into gitextensions:master Oct 7, 2023
3 of 4 checks passed
@ghost ghost added this to the vNext milestone Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants