Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Hexa editor display of binary files #11747

Merged
merged 2 commits into from
May 24, 2024
Merged

fix Hexa editor display of binary files #11747

merged 2 commits into from
May 24, 2024

Commits on May 24, 2024

  1. fix Hexa editor display of binary files 

    by:
* reading file and blob with a better encoding
* not touching/altering *blob* content (i.e not breaking content by reencoding)
* not converting in ASCII before doing the Hexa editor display (it breaks char > 0x80)

As a result, display is **exactly** the same obtained by using an external Hexa Editor:
* Hexa value are accurate
* string display is the same
(except some cheating done by hexa editor
for example with char 0x99 displayed as ™)
    @pmiossec
    pmiossec committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0b42bff View commit details
    Browse the repository at this point in the history

  2. refactor display binary as hex dump 

    * DRY
* add display in MB (more human friendly) & translated
    @pmiossec
    pmiossec committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c15e105 View commit details
    Browse the repository at this point in the history