Add "Close (go to Dashboard) to repos dropdown

[RussKie]

Proposed changes

• Extract the working directory / recent repositories dropdown as a standalone component
• Add "Close (go to Dashboard) to repos dropdown

Screenshots

After

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

---

✒️ I contribute this code under The Developer Certificate of Origin.

[pmiossec]

This comment is still valid: #10906 (comment)

I just discovered that the 1st commit introduce a frustrating new behavior/regression if the mouse don't go straight down:
If you hover an element of the toolbar, the dropdown disappear immediately (which is not the case in last master where the dropdown stay open):

[mstv]

I extracted the first two commits as #11751 as those should be contentious-free.

This comment is still valid: #10906 (comment)

Why create hacks - spread over half of the class - for problems with synchronous execution of overridden methods if it works without pain using event handlers?

[mstv]

This comment is still valid: #10906 (comment)

Moreover, closing the dropdown does / not work randomly.

[RussKie]

That's bizarre....

…

On Sun, 26 May 2024, 3:00 am Michael Seibt, ***@***.***> wrote: This comment is still valid: #10906 (comment) <#10906 (comment)> Moreover, closing the dropdown does / not work randomly. — Reply to this email directly, view it on GitHub <#11751 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBTEXULXMMKOSG4TGNNGQTZEC7RXAVCNFSM6AAAAABIGXT2C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGM3DCMZXGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[RussKie]

Why create hacks - spread over half of the class - for problems with synchronous execution of overridden methods if it works without pain using event handlers?

You've lost me. Could you please elaborate?

[RussKie]

This comment is still valid: #10906 (comment)

I just discovered that the 1st commit introduce a frustrating new behavior/regression if the mouse don't go straight down:
If you hover an element of the toolbar, the dropdown disappear immediately (which is not the case in last master where the dropdown stay open):

I think I found the reason - I lost the call to the base:

        protected override void OnDropDownShow(EventArgs e)
        {
+           base.OnDropDownShow(e);

Now, it's all working:

11751.mp4

[mstv]

seems to work

Why isn't there a change to English.xlf?

[RussKie]

Why isn't there a change to English.xlf?

Because we're reusing the existing text from FormBrowse. This is achieved with:

        void ITranslate.AddTranslationItems(ITranslation translation)
        {
            TranslationUtils.AddTranslationItemsFromFields("FormBrowse", this, translation);
        }

        void ITranslate.TranslateItems(ITranslation translation)
        {
            TranslationUtils.TranslateItemsFromFields("FormBrowse", this, translation);
        }

[pmiossec]

Now, it's all working:

👍

I pushed 2 fixup commits to fix hotkeys.

[RussKie]

Thank you @pmiossec

[RussKie]

Thank you folks