Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Archive..." to context menu of File tree tab / Archive filter by path #1868

Merged
merged 5 commits into from May 26, 2013

Conversation

feinstaub
Copy link
Contributor

see next comment

@feinstaub
Copy link
Contributor Author

New context menu entry "Archive..." in file tree tab:
2013-05-26_15-27-17_gitextensions feature_archive_with_path - git extensions -_ debug _-

"Archiv..." opens Archive dialog with preselected filter path settings (which are also new):
2013-05-26_15-28-28_archive

@feinstaub
Copy link
Contributor Author

In c374690 the GitUICommands.cs has got many additions and deletions due to whitespace differences which I unable to see using tools like kdiff3. This happens when I save the file with Visual Studio or Notepad++. Interestingly if I now checkout the previous revision 91079be then the GitUICommands.cs has got these additions and deletions right after checkout.

My question is now which of the two versions of the file have the correct encoding or whatever is causing this behaviour (or: is something wrong with my machine or the file itself?)? Any ideas?

@jbialobr
Copy link
Member

My question is now which of the two versions of the file have the correct encoding or whatever is causing this behaviour (or: is something wrong with my machine or the file itself?)? Any ideas?

It was not normalized eol repository problem.

@jbialobr jbialobr merged commit c374690 into gitextensions:master May 26, 2013
var selectedRevisions = RevisionGrid.GetSelectedRevisions();
if (selectedRevisions.Count != 1)
{
MessageBox.Show("Select exactly one revision.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe disable archive item?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep it like this until the following is resolved: how to handle File tree tab when multiple revisions are selected?

  • Option 1: diable the File tree completely
  • Option 2: make it clear to the user which of the seleted revisions is shown [preferred]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants