Implementation of issue #1582

[jbialobr]

I think it is ready for tests and review.

[feinstaub]

I very much like that the << is hidden when Effective is not chosen:

[feinstaub]

In "Revision links" settings: when creating a new "category" in Effective it will be stored in "Global for all repos" settings source. Is this intended?

[jbialobr]

Yes, the idea is to set setting at the lowest possible level.

[feinstaub]

"lowest" in the the sense of "with most impact"?

[jbialobr]

"lowest" - the lowest level that has to be overriden to take effect on effective view

[jbialobr]

There is exception for "Distributed with current repository" - it can't be set via effective view.

[feinstaub]

so the more "low" the more "global" the setting is stored? EDIT: Or am I thinking in the wrong terms?

[jbialobr]

Yes

[feinstaub]

Two small thinks:

1. Why not using standard check box for "Enabled" (with check box on the left)?
   
2. There are two search text boxes: just for convenience to have two expressions combined with "or"?

[jbialobr]

1. I think this way is consistent with other captions.
2. Search pattern is for matching fragment, but not necessary whole matched fragment has to be used in a link. For the case you don't want whole matched fragment you can use "Nested pattern" (I can see caption on your picture) to extract desired fragment. Here is an example https://github.com/gitextensions/gitextensions/blob/jb/RevisionLinks%231582/GitExtensions.settings#L23.

[feinstaub]

1. I've seen that at a few other places in GitExt but not in other software that I use. I find it a bit confusing (although I see the intention of the equal aligment of the boxes; I like it for example more when I am able to also click on the text caption to trigger the checkbox)
2. Now I see the "Nested pattern", too. But there is a bug: when I open the Settings Dialog and then go to Revision links I see the caption. As soon as I choose for example "Local for current repo" the caption disappears as in the screenshot

[jbialobr]

1. Could you provide srceenshot that shows how you would like to place it on the form?
2. Thanks, fixed.

[vbjay]

The checkboxes are fine like that. If all labels are aligned that way then it is clear where the checkbox's caption is. The search in is clear that you are choosing different places to search in. Enabled doesn't have a sub item. It is a setting of its own.

[feinstaub]

1. Maybe like this:
   

or this (right aligned rest of the captions):

or put Enabled to top:

In my view the "Enabled" checkbox serves a different purpose compared to the other controls ("enabled/not enabled" vs. "configuration details") and therefore their is no need to make it look "consistent".

[jbialobr]

For me it looks like a developer forgot to align this checkbox in your examples.

[feinstaub]

similar example taken from VLC with an Enable checkbox:

MS Word autocorrection options with "out of line" checkbox:

Inkscape with checkboxes and other controls:

So don't get me wrong, I'm not so much eager to discuss aesthetics of the current design vs. my screenshots but to point out that the checkbox box without caption on the right is very non-standard and I actually cannot come up with a popular program that uses this non-standard design.

[jbialobr]

Maybe next to the name textbox is better?

[feinstaub]

Maybe next to the name textbox is better?

I like this solution. :) (in the screenshot maybe the Name textbox width could be a bit larger for more elaborate names).

[jbialobr]

Thanks, ok.