Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configurable "Number of previous messages in commit dialog" #2046

Merged
merged 8 commits into from
Oct 8, 2013
Merged

User configurable "Number of previous messages in commit dialog" #2046

merged 8 commits into from
Oct 8, 2013

Conversation

ulrichb
Copy link
Contributor

@ulrichb ulrichb commented Oct 3, 2013

See #1571

@jbialobr
Copy link
Member

jbialobr commented Oct 4, 2013

There is already too many entries on "Git Extensions" page. There should be a separate page for settings related to Commit dialog. (see #2048)

@ulrichb
Copy link
Contributor Author

ulrichb commented Oct 6, 2013

OK. If you want, I create an own "Commit Dialog" settings section for all the "commit" stuff in the settings window.

Could you provide a list of items, which you want to be moved? Should I do it within this pull request? Moving all commit dialog settings (#2048) should be an own pull request.

@jbialobr
Copy link
Member

jbialobr commented Oct 6, 2013

That would be great. I updated #2048 with details.

Should I do it within this pull request?

As you wish.

@ulrichb
Copy link
Contributor Author

ulrichb commented Oct 6, 2013

OK. I rebased my feature branch on the current master and did the necessary changes for this pull request (we have a new commit dialog page including 3 moved settings from GitExtensionsSettingsPage).

@jbialobr
Copy link
Member

jbialobr commented Oct 7, 2013

Great. Could you update the documentation, or raise an Issue to indicate that documentation updates are required as described here

@jbialobr
Copy link
Member

jbialobr commented Oct 7, 2013

Could you use layout manager to position controls?
2013-10-07 13_23_21-settings - commit dialog

@ulrichb
Copy link
Contributor Author

ulrichb commented Oct 7, 2013

Later I will provide an own PR with a rebuilt GitExtensionsSettingsPage using a layout manager.

@jbialobr jbialobr merged commit 0c7590e into gitextensions:master Oct 8, 2013
@jbialobr
Copy link
Member

jbialobr commented Oct 8, 2013

Thanks.
I wonder if it would be better to create a queue of size of CommitDialogNumberOfPreviousMessages. It would allow to share last commit messages between different repositories/branches.
What do you think?

@ulrichb
Copy link
Contributor Author

ulrichb commented Oct 15, 2013

I wonder if it would be better to create a queue of size of CommitDialogNumberOfPreviousMessages. It would allow to share last commit messages between different repositories/branches.

For me its more important to have the last few messages of HEAD. But yes, it would be cool to have both, so that the menu looks like:

Your last x messages:
  Message a
  Message b
  Message c
Last y HEAD messages:
  Message a
  Message c
  Message d
--------------------------------
Generate a list of changes in s...

@feinstaub
Copy link
Contributor

it would be cool to have both

+1

@jbialobr
Copy link
Member

I like it, when one doesn't want to have one of them he can set x or y to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants