Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tfs2015 build integration #3219

Merged
merged 3 commits into from
Mar 28, 2017

Conversation

kine
Copy link
Contributor

@kine kine commented Jun 23, 2016

Solution for issue #3177. I have used nugget packages for TFS2015 REST API, because I am not C# developer and it was easier for me than working with bare REST. But I think it could be rewritten to clean REST if needed (https://www.visualstudio.com/en-us/docs/integrate/api/overview).

kine added 3 commits June 23, 2016 07:30
Tab control shows only link to open the report. Loading the full report into
tab was too slow and the GUI was slow. I have not found any link in TFS2015 to
show "simplified" report for the build.
@pmiossec
Copy link
Member

I would have prefered to use the REST API :(
When I have developed the TFS plugin for the previous version, I was already worried by being obliged to include references on tfs assemblies. It could sometimes bring some impediments when building...
I was quite happy when heard that TFS2013 (partly) and TFS2015 introduced a REST API.
I think that the REST API is here to stay and that we should do the effort to support it. That way, we will support the actual TFS versions and the next to come...

@jbialobr
Copy link
Member

@pmiossec What kind of impediments do you think about?

@pmiossec
Copy link
Member

pmiossec commented Jul 1, 2016

Impediments is perhaps a little overstated but for each tfs project (2012, 2013 and now 2015), you will have to add the tfs assemblies and package them with GitExtensions with something that could be done not so hardly but using the REST API.

And TFS2015 is adding 15Mo, a lot more than the 2Mo (2012) or 5Mo (2013) previously needed.

@vbjay
Copy link
Contributor

vbjay commented Jul 1, 2016

That is the whole point of nuget. It will pull down he right things and
even restore if the packages don't exist.

On Fri, Jul 1, 2016 at 5:24 PM Philippe Miossec notifications@github.com
wrote:

Impediments is perhaps a little overstated but for each tfs project (2012,
2013 and now 2015), you will have to add the tfs assemblies and package
them with GitExtensions with something that could be done not so hardly but
using the REST API.

And TFS2015 is adding 15Mo, a lot more than the 2Mo (2012) or 5Mo (2013)
previously needed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3219 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADdhsdhNdaDU1P7G2Ps12wgsRfj8tgJXks5qRYV1gaJpZM4I8ebO
.

@KindDragon
Copy link
Contributor

So what do we do with this PR? Vote with GitHub reaction 😄

@jbialobr
Copy link
Member

Nowadays 15MB is only a few seconds added to the download time. I vote for merging to enable the feature sooner.

@jbialobr jbialobr added this to the 2.50 milestone Mar 22, 2017
@jbialobr jbialobr merged commit 0d67be6 into gitextensions:master Mar 28, 2017
@VictorioBerra
Copy link

Just installed 2.50 I dont see the TFS integration in the plugins menu. I was pretty sure it was set to install the feature in the installer. What am I missing?

@pmiossec
Copy link
Member

It seems that a lot of needed assemblies (Microsoft.TeamFoundation.*, Microsoft.VisualStudio.*, ....) are not bundled in the setup :(

And TfsInterop.Vs2013.dll is no more bundled too (perhaps not build too...) :(

Once again, I think the best way to fix definitively all these problems (and support tfs2017) is to use the rest api. See #3779 (comment)

@EbenZhang
Copy link
Contributor

EbenZhang commented Jun 29, 2017

in2.49 or even 2.48, the dlls for earlier version of tfs were not bundled. i think the one who use this integration should use Microsoft's installer to install the dlls to gac.

@pmiossec
Copy link
Member

@EbenZhang yes but that's not the way Microsoft provide tfs assemblies since TFS2015.
Dlls are no more added to the GAC and you should use nuget packages.

From https://www.visualstudio.com/en-us/docs/integrate/get-started/client-libraries/dotnet :

For .NET developers building Windows apps and services that integrate with Visual Studio Team Services, client libraries are available for integrating with work item tracking, version control, build, and other services are now available. These packages replace the traditional TFS Client OM installer and make it easy to acquire and redistribute the libraries needed by your app or service.

@EbenZhang
Copy link
Contributor

thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants