Added "bugfix" kind of branch #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Jul 10, 2017
Plugins/GitFlow/GitFlowForm.cs
Outdated
| @@ -160,7 +161,7 @@ private void DisplayBranchDatas() | |||
| private void LoadBaseBranches() | |||
| { | |||
| var branchType = cbType.SelectedValue.ToString(); | |||
| var manageBaseBranch = (branchType == Branch.feature.ToString("G") || branchType == Branch.hotfix.ToString("G") || branchType == Branch.support.ToString("G")); | |||
| var manageBaseBranch = (branchType == Branch.feature.ToString("G") || branchType == Branch.hotfix.ToString("G") || branchType == Branch.support.ToString("G") || branchType == Branch.bugfix.ToString("G")); | |||
There was a problem hiding this comment.
if manageBaseBranch is anything but Branch.release shouldn't it be simplified to
var manageBaseBranch = branchType != Branch.release.ToString("G");
There was a problem hiding this comment.
You're right, just pushed the change.
RussKie
approved these changes
Jul 10, 2017
Bugfix kind of branch added into LoadBaseBranch Check changed on manageBaseBranch
This was referenced Mar 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature #3811
Changes proposed in this pull request:
How did I test this code: