Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cherry-picking multiple commits from FormBrowse menu #3852

Conversation

crypto-rsa
Copy link
Contributor

The ability to do so from the RevisionGrid context menu has been added in commit b3e7944.

A followup fix for #2396.

Changes proposed in this pull request:

  • Cherry-picking uses the same code regardless of whether it is run from the RevisionGrid context menu or FormBrowse window menu.

How did I test this code:

  • Selected some commits from a different branch (not necessarily in chronological order)
  • Clicked Commands - Cherry pick...
  • The Cherry-pick form appeared sequentially for each of the selected commits (this time in chronological order)

Has been tested on

  • GIT 2.13
  • Windows 10

The ability to do so from the RevisionGrid context menu has been added in commit
b3e7944.
MessageBox.Show("Select exactly one revision.");
return;
}
var revisions = RevisionGrid.GetSelectedRevisions(System.DirectoryServices.SortDirection.Descending);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth checking for null or Length < 1 and return early

@jbialobr jbialobr merged commit b4883a5 into gitextensions:release/2.50 Jul 17, 2017
@crypto-rsa crypto-rsa deleted the allow-multi-cherrypick-from-FormBrowse-menu branch July 17, 2017 16:26
@jbialobr jbialobr added this to the 2.50.02 milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants