Rename arguments related to diff to firstRevision, secondRevision to … #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have a consistent naming This was discussed in gitextensions#4313, the core files in the PR was changed already firstRevision/secondRevision was the most commonly used arguments. Some arguments have been aligned to from/to in gitextensions#4031 PRs. Other names discussed was revA/revB.
RussKie
approved these changes
Jan 11, 2018
RussKie
reviewed
Jan 11, 2018
GitCommands/Git/GitModule.cs
Outdated
| @@ -2213,7 +2213,7 @@ public IList<GitStash> GetStashes() | |||
| return stashes; | |||
| } | |||
|
|
|||
| public Patch GetSingleDiff(string @from, string to, string fileName, string oldFileName, string extraDiffArguments, Encoding encoding, bool cacheResult, bool isTracked=true) | |||
| public Patch GetSingleDiff(string @firstRevision, string secondRevision, string fileName, string oldFileName, string extraDiffArguments, Encoding encoding, bool cacheResult, bool isTracked=true) | |||
|
Squash and good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…have a consistent naming
No functionality change, just renaming of arguments.
For those that are reviewing(also without commit privileges), if you agree, please add a comment about that.
If you have better names, suggest that too.
This was discussed in #4313, the core files in the PR was changed already
firstRevision/secondRevision was the most commonly used arguments. Some arguments have been aligned to from/to in #4031 PRs.
Other names discussed was revA/revB.
What did I do to test the code and ensure quality:
Has been tested on (remove any that don't apply):